eglantine-cirakg/src/common/assert.h, branch nx2

[common/logging] Simplify logging logic and fix issues when logging before system is created (#3688)

2026-03-12T17:29:15+00:00

- our logging code was bigger than spdlog itself, why???? just keep it simple - fix issues when logging before logging system is even started - removes the "initialized logging twice" issue - removes uneeded indirection in file logging - uses direct formatting instead of jumping hoopla-around the fmt::format() ressult - code duplication and dead code removal as usual I did explore dup2() but I think it's not worth the hassle I did try `fwopen()` but it's better if things are just kept as-is. there is a lot of noise because I removed a bunch of redundant files on logging and just put everything in one file now normally this wouldn't be a good idea, however consider: the complexity of logging; it's less than 500 lines... does it really need a whole subsystem?!?!?! ITS JUST LOGGING Signed-off-by: lizzie Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3688 Reviewed-by: crueter Reviewed-by: DraVee Reviewed-by: CamilleLaVey Co-authored-by: lizzie Co-committed-by: lizzie

[chore] Resolve "warning C4127: conditional expression is constant" while building under MSVC (#3567)

2026-02-21T02:01:19+00:00

NINJA REPORTS THIS SHIT ALMOST EVERY STEP! [161/863] Building CXX object src\hid_core\CMakeFiles\hid_core.dir\frontend\input_interpreter.cpp.obj D:\dev\eden\src\.\core/hle/kernel/k_auto_object.h(100): warning C4127: conditional expression is constant D:\dev\eden\src\.\core/hle/kernel/k_auto_object.h(100): note: consider using 'if constexpr' statement instead D:\dev\eden\src\.\core/hle/kernel/k_memory_manager.h(246): warning C4127: conditional expression is constant D:\dev\eden\src\.\core/hle/kernel/k_memory_manager.h(246): note: consider using 'if constexpr' statement instead The reason, any mention to UNIMPLEMENTED() macro reaches this point where a constant expression (macro argument) is not declared so. There must be several other ways to suppress, like via cmake C4127 suppression or making every source constexpr, but lazy. Since it's an unimplemented() feature assert call, i`ve just made it non constant. Covers everything. No charges. Signed-off-by: xbzk Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3567 Reviewed-by: Lizzie Reviewed-by: DraVee Reviewed-by: CamilleLaVey Co-authored-by: xbzk Co-committed-by: xbzk

[common] remove assert extra newline (#3362)

2026-01-26T16:21:57+00:00

Signed-off-by: lizzie Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3362 Reviewed-by: Maufeat Reviewed-by: DraVee Co-authored-by: lizzie Co-committed-by: lizzie

[common] asserts now display expression of assert (#2997)

2025-12-01T04:06:57+00:00

Easiest change in the world, will help to pinpoint asserts quicker, it's just a relatively small thing so doesn't even need testing. Signed-off-by: lizzie lizzie@eden-emu.dev Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2997 Reviewed-by: Caio Oliveira Reviewed-by: CamilleLaVey Co-authored-by: lizzie Co-committed-by: lizzie

[common] Do not expose platform specific Crash() macro that is only used ever once (#2909)

2025-11-03T20:07:30+00:00

thing is only ever used once and its also platform specific... uh Signed-off-by: lizzie Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2909 Reviewed-by: crueter Reviewed-by: Shinmegumi Reviewed-by: MaranBr Reviewed-by: Caio Oliveira Co-authored-by: lizzie Co-committed-by: lizzie

Enable compiler optimizations and enforce x86-64-v2 on GCC/Clang (#9442)

2022-12-18T01:16:52+00:00

* Testing LTO (#4) * Testing LTO * clang * linux * Added the rest of Blinkhawk's optimizations * Unlikely asserts * Removing LTO from Linux builds - GCC * Removing LTO from Linux builds - Clang

common/assert: rework ASSERT handling to avoid std::function usage

2022-06-14T00:09:32+00:00

common: Don't test ASSERT conditions inline

2022-06-14T00:09:00+00:00

common: Change semantics of UNREACHABLE to unconditionally crash

2022-06-14T00:09:00+00:00

chore: add missing SPDX tags

2022-04-28T16:24:11+00:00

Follow-up to 2b87305d319f0bd04da36fb96314934f37b12637