eglantine-cirakg/src/common/misc.cpp, branch nx2

common: Move error handling to error.cpp/h

2021-09-11T21:19:14+00:00

This allows us to avoid implicitly including every time common_funcs.h is included.

[network] Error handling reform

2021-02-28T22:25:31+00:00

`network.cpp` has several error paths which either: - report "Unhandled host socket error=n" and return `SUCCESS`, or - switch on a few possible errors, log them, and translate them to Errno; the same switch statement is copied and pasted in multiple places in the code Convert these paths to use a helper function `GetAndLogLastError`, which is roughly the equivalent of one of the switch statements, but: - handling more cases (both ones that were already in `Errno`, and a few more I added), and - using OS functions to convert the error to a string when logging, so it'll describe the error even if it's not one of the ones in the switch statement. - To handle this, refactor the logic in `GetLastErrorMsg` to expose a new function `NativeErrorToString` which takes the error number explicitly as an argument. And improve the Windows version a bit. Also, add a test which exercises two random error paths.

General: Make ignoring a discarded return value an error

2020-10-30T04:13:21+00:00

Allows our CI to catch more potential bugs. This also removes the [[nodiscard]] attribute of IOFile's Open member function. There are cases where a file may want to be opened, but have the status of it checked at a later time.

Port #4182 from Citra: "Prefix all size_t with std::"

2018-09-15T13:21:06+00:00

common/misc: use windows.h

2018-08-13T20:28:24+00:00

linux-mingw does not really like this.

common/misc: Deduplicate code in GetLastErrorMsg()

2018-07-19T13:15:38+00:00

Android and macOS have supported thread_local for quite a while, but most importantly is that we don't even really need it. Instead of using a thread-local buffer, we can just return a non-static buffer as a std::string, avoiding the need for that quality entirely.

Remove empty newlines in #include blocks.

2016-09-21T02:15:47+00:00

This makes clang-format useful on those. Also add a bunch of forgotten transitive includes, which otherwise prevented compilation.

Sources: Run clang-format on everything.

2016-09-18T00:38:01+00:00

Common: Cleanup memory and misc includes.

2015-06-27T23:36:54+00:00

Common: Remove common.h

2015-05-07T18:45:22+00:00