eglantine-cirakg/src/core/file_sys/nup_container.cpp, branch nx2Mirror of github.com/cira0100/Eglantine-public nx2, a fork of Djihads80/Eglantine.https://git.cirakg.xyz/eglantine-cirakg/atom?h=nx22026-11-02T19:53:47+00:00file_sys: reject NUP tables with wrapping bounds or cyclic directories2026-11-02T19:53:47+00:00Sssnowyyy78863999+Sssnowyyy@users.noreply.github.com2026-11-02T16:25:26+00:00urn:sha1:089105ab44c87f1ef0526221144a1979c56558e6
31b901b93b checked the TOC with unchecked arithmetic on counts and
offsets read from the file. The record-table size (u64 count times
record size) and u32 first_child + child_count can wrap, so the bounds
checks pass and later reads go out of bounds; the same holds for the
TOC range, name ranges, file extents and the meta range. A directory
that lists its own ancestor as a child also made BuildDirTree recurse
until the stack overflowed.
Bound the counts by the TOC size before multiplying, compare ranges by
subtraction, and widen the child range to u64. Walk the directory graph
once after parsing with an explicit stack and reject cycles and nesting
deeper than 128, so BuildDirTree can no longer recurse without bound.
The file is rejected with ErrorNUPBadFormat.
Assisted-by: Claude Sonnet 5.5 (implementation and commit message)
file_sys: decompress large NUP zstd members once2026-11-02T19:53:47+00:00Sssnowyyy78863999+Sssnowyyy@users.noreply.github.com2026-11-02T16:23:37+00:00urn:sha1:8748fbd542a00ab7bbfbf17210b29f8d51c3c4b5
31b901b93b only cached a zstd member while it fit the 512 MiB cache.
Anything larger was never cached, so every Read() allocated the full
uncompressed size and decompressed the whole extent again, which makes a
multi-GB RomFS read in small chunks unusably slow. Members between 256
and 512 MiB evicted each other on alternate reads, and Insert copied the
vector so memory briefly doubled. Two threads decompressing the same
member also left a duplicate LRU entry and a wrong byte count.
The writer emits one zstd frame per member, so there are no frame
boundaries to seek by. Members larger than half the cache are now
streamed once into a temporary file under the cache directory and read
from there, using bounded memory. The file is removed when the
container is released. Smaller members stay in the LRU, which now moves
the vector in and ignores a duplicate insert.
Assisted-by: Claude Sonnet 5.5 (implementation and commit message)
nup_container: update record layouts to aligned NUP v1 fields2026-11-02T02:38:53+00:00a55uka59313695+a55uka@users.noreply.github.com2026-11-02T01:41:05+00:00urn:sha1:b8d2c08d6efd312620b066cdab2f0238ebc94a26loader: add NUP (Unencrypted (Archival) Package) container support2026-11-01T18:53:47+00:00a55uka59313695+a55uka@users.noreply.github.com2026-11-01T18:53:47+00:00urn:sha1:31b901b93b992580d608fc2f4db9ddac1d755e43