eglantine-cirakg/src/video_core/host1x/syncpoint_manager.h, branch nx2Mirror of github.com/cira0100/Eglantine-public nx2, a fork of Djihads80/Eglantine.https://git.cirakg.xyz/eglantine-cirakg/atom?h=nx22026-10-30T20:57:51+00:00nx2: ignore syncpoint signals past the syncpoint table2026-10-30T20:57:51+00:00Takoroka137927095+Takoroka@users.noreply.github.com2026-10-30T20:35:21+00:00urn:sha1:affa8969acb3f1fe32933a79b7b1e8612e3afd44
The 3D engine's sync method and the puller's fence action take a
syncpoint id from the command list and signal it, but the syncpoint
manager has 192 syncpoints and does not check the index. Command words
read wrong (Splatoon Raiders on Linux runs 3D engine commands as puller
methods 0x10-0x3F just before) made Maxwell3D signal a syncpoint past
the table: SyncpointManager::Increment walked memory after its action
lists as a list and crashed on a null link (SIGSEGV reading 0x10).
Builds 49 and 50 both crashed this way under WSL. FenceManager now drops
such signals with an error, for every engine that signals.
host1x/syncpoint_manager: Eliminate unnecessary std::function construction2022-11-29T13:58:50+00:00Lioncashmathew1800@gmail.com2022-11-29T13:58:47+00:00urn:sha1:225f5ba19ffbdf0ef1b856697deba95b3ad79bdf
We can just pass the function object through, and if it's a valid
function, then it will automatically be converted.
host1x/syncpoint_manager: Pass DeregisterAction() handle as const-ref2022-11-29T13:55:33+00:00Lioncashmathew1800@gmail.com2022-11-29T13:55:30+00:00urn:sha1:b03305859e38b01c3530c6f2dbcc97b6b72dc8ee
The handle is only compared against and not modified in any way, so we
can pass it by const reference.
This also allows us to mark the respective parameters for
DeregisterGuestAction() and DeregisterHostAction() as const references
as well.
General: address feedback2022-10-06T19:00:54+00:00Fernando Sahmkowfsahmkow27@gmail.com2022-09-01T03:45:22+00:00urn:sha1:1595e779132e228bcd0984b6402d351ddfe981a8general: Format licenses as per SPDX guidelines2022-10-06T19:00:54+00:00Morph39850852+Morph1984@users.noreply.github.com2022-06-29T23:27:49+00:00urn:sha1:5ee9e5e84bf0b6601bd45a7cfa1ee8962e856a3aGeneral: Fix clang format.2022-10-06T19:00:53+00:00Fernando Sahmkowfsahmkow27@gmail.com2022-06-16T00:12:21+00:00urn:sha1:2f61540d4450cee062dc03221ff81b95a7f39aa0VideoCore: Refactor syncing.2022-10-06T19:00:52+00:00Fernando Sahmkowfsahmkow27@gmail.com2022-01-30T09:31:13+00:00urn:sha1:a6425c97e4ac5d16b2c34936f59a00b308a54da1