aboutsummaryrefslogtreecommitdiff
path: root/src/core/hle/kernel/mutex.cpp
Commit message (Collapse)AuthorAgeFilesLines
* kernel: Remove unnecessary includesLioncash2019-12-071-0/+1
| | | | | | Over the course of the changes to the kernel code, a few includes are no longer necessary, particularly with the change over to std::shared_ptr from Boost's intrusive_ptr.
* core/memory: Migrate over Write{8, 16, 32, 64, Block} to the Memory classLioncash2019-11-261-2/+2
| | | | | | | | | The Write functions are used slightly less than the Read functions, which make these a bit nicer to move over. The only adjustments we really need to make here are to Dynarmic's exclusive monitor instance. We need to keep a reference to the currently active memory instance to perform exclusive read/write operations.
* core/memory: Migrate over Read{8, 16, 32, 64, Block} to the Memory classLioncash2019-11-261-1/+1
| | | | | | | | | | | | | | With all of the trivial parts of the memory interface moved over, we can get right into moving over the bits that are used. Note that this does require the use of GetInstance from the global system instance to be used within hle_ipc.cpp and the gdbstub. This is fine for the time being, as they both already rely on the global system instance in other functions. These will be removed in a change directed at both of these respectively. For now, it's sufficient, as it still accomplishes the goal of de-globalizing the memory code.
* kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for ↵bunnei2019-11-241-10/+12
| | | | | | | | kernel objects. (#3154) * kernel: Replace usage of boost::intrusive_ptr with std::shared_ptr for kernel objects. - See https://github.com/citra-emu/citra/pull/4710 for details.
* Kernel: Correct Results in Condition Variables and MutexesFernando Sahmkow2019-10-151-0/+1
|
* Kernel: Style and CorrectionsFernando Sahmkow2019-10-151-1/+1
|
* Add PrepareReschedule where required.Fernando Sahmkow2019-10-151-0/+2
|
* core/hle/kernel/mutex: Remove usages of global system accessorsLioncash2019-03-141-11/+15
| | | | | Removes the use of global system accessors, and instead uses the explicit interface provided.
* core/hle/kernel: Make Mutex a per-process class.Lioncash2019-03-141-2/+7
| | | | | | | Makes it an instantiable class like it is in the actual kernel. This will also allow removing reliance on global accessors in a following change, now that we can encapsulate a reference to the system instance in the class.
* general: Remove unused boost inclusions where applicableLioncash2018-10-301-2/+0
| | | | Cleans up unused includes and trims off some dependencies on externals.
* kernel/mutex: Amend behavior of TransferMutexOwnership()Lioncash2018-10-061-1/+1
| | | | | | | | | This was the result of a typo accidentally introduced in b355b43bfafc390389906731c0f131c712f9089d. This restores the previous correct behavior. The behavior with the reference was incorrect and would cause some games to fail to boot.
* kernel/thread: Make all instance variables privateLioncash2018-10-041-17/+17
| | | | | | | | | | | | | | | | | | | | Many of the member variables of the thread class aren't even used outside of the class itself, so there's no need to make those variables public. This change follows in the steps of the previous changes that made other kernel types' members private. The main motivation behind this is that the Thread class will likely change in the future as emulation becomes more accurate, and letting random bits of the emulator access data members of the Thread class directly makes it a pain to shuffle around and/or modify internals. Having all data members public like this also makes it difficult to reason about certain bits of behavior without first verifying what parts of the core actually use them. Everything being public also generally follows the tendency for changes to be introduced in completely different translation units that would otherwise be better introduced as an addition to the Thread class' public interface.
* arm_interface: Replace kernel vm_manager include with a forward declarationLioncash2018-09-201-0/+1
| | | | | | Avoids an unnecessary inclusion and also uncovers three places where indirect inclusions were relied upon, which allows us to also resolve those.
* kernel/mutex: Replace ResultCode construction for invalid addresses with the ↵Lioncash2018-09-171-2/+2
| | | | | | | | named variant We already have a ResultCode constant for the case of an invalid address, so we can just use it instead of re-rolling that ResultCode type.
* kernel: Eliminate kernel global stateLioncash2018-08-281-3/+3
| | | | | | | | | | | | | | | | | | | | | | As means to pave the way for getting rid of global state within core, This eliminates kernel global state by removing all globals. Instead this introduces a KernelCore class which acts as a kernel instance. This instance lives in the System class, which keeps its lifetime contained to the lifetime of the System class. This also forces the kernel types to actually interact with the main kernel instance itself instead of having transient kernel state placed all over several translation units, keeping everything together. It also has a nice consequence of making dependencies much more explicit. This also makes our initialization a tad bit more correct. Previously we were creating a kernel process before the actual kernel was initialized, which doesn't really make much sense. The KernelCore class itself follows the PImpl idiom, which allows keeping all the implementation details sealed away from everything else, which forces the use of the exposed API and allows us to avoid any unnecessary inclusions within the main kernel header.
* kernel: Move object class to its own source filesLioncash2018-08-011-1/+1
| | | | | | General moving to keep kernel object types separate from the direct kernel code. Also essentially a preliminary cleanup before eliminating global kernel state in the kernel code.
* Merge pull request #877 from lioncash/removebunnei2018-07-311-1/+0
|\ | | | | kernel: Remove unused object_address_table.cpp/.h
| * kernel: Remove unused object_address_table.cpp/.hLioncash2018-07-311-1/+0
| | | | | | | | | | | | These source files were entirely unused throughout the rest of the codebase. This also has the benefit of getting rid of a global variable as well.
* | kernel: Remove unnecessary includesLioncash2018-07-311-0/+4
|/ | | | | Removes unnecessary direct dependencies in some headers and also gets rid of indirect dependencies that were being relied on to be included.
* mutex: Pass SharedPtr to GetHighestPriorityMutexWaitingThread() by referenceLioncash2018-07-231-1/+1
| | | | | The pointed to thread's members are simply observed in this case, so we don't need to copy it here.
* thread: Convert ThreadStatus into an enum classLioncash2018-07-191-3/+3
| | | | | Makes the thread status strongly typed, so implicit conversions can't happen. It also makes it easier to catch mistakes at compile time.
* Kernel/Arbiters: Add stubs for 4.x SignalToAddress/WaitForAddres SVCs.Michael Scire2018-06-211-2/+2
|
* Mutex: Do not assert when the mutex waiting threads list isn't empty on ↵Subv2018-05-201-1/+0
| | | | | | mutex release. A thread may own multiple mutexes at the same time, and only release one of them while other threads are waiting for the other mutexes.
* Kernel: Implemented mutex priority inheritance.Subv2018-04-231-8/+31
| | | | | | | Verified with a hwtest and implemented based on reverse engineering. Thread A's priority will get bumped to the highest priority among all the threads that are waiting for a mutex that A holds. Once A releases the mutex and ownership is transferred to B, A's priority will return to normal and B's priority will be bumped.
* Kernel: Remove old and unused Mutex code.Subv2018-04-201-120/+0
|
* Kernel: Corrected the implementation of svcArbitrateLock and svcArbitrateUnlock.Subv2018-04-201-0/+94
| | | | | | | | | | Switch mutexes are no longer kernel objects, they are managed in userland and only use the kernel to handle the contention case. Mutex addresses store a special flag value (0x40000000) to notify the guest code that there are still some threads waiting for the mutex to be released. This flag is updated when a thread calls ArbitrateUnlock. TODO: * Fix svcWaitProcessWideKey * Fix svcSignalProcessWideKey * Remove the Mutex class.
* mutex: Update hasWaiters on release.bunnei2018-02-051-0/+1
|
* mutex: Remove unused call to VerifyGuestState.bunnei2018-01-081-3/+0
|
* Kernel: Properly keep track of mutex lock data in the guest memory. This ↵Subv2018-01-081-54/+43
| | | | fixes userland locking/unlocking.
* svc: Implement svcLockMutex.bunnei2018-01-011-18/+63
|
* Merge remote-tracking branch 'upstream/master' into nxbunnei2017-10-091-2/+3
|\ | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | # Conflicts: # src/core/CMakeLists.txt # src/core/arm/dynarmic/arm_dynarmic.cpp # src/core/arm/dyncom/arm_dyncom.cpp # src/core/hle/kernel/process.cpp # src/core/hle/kernel/thread.cpp # src/core/hle/kernel/thread.h # src/core/hle/kernel/vm_manager.cpp # src/core/loader/3dsx.cpp # src/core/loader/elf.cpp # src/core/loader/ncch.cpp # src/core/memory.cpp # src/core/memory.h # src/core/memory_setup.h
| * Fixed type conversion ambiguityHuw Pascoe2017-09-301-1/+1
|/
* Kernel/Mutex: Propagate thread priority changes to other threads inheriting ↵Subv2017-01-041-38/+22
| | | | the priority via mutexes
* Kernel/Mutex: Update a mutex priority when a thread stops waiting on it.Subv2017-01-041-13/+22
|
* Kernel/Mutex: Implemented priority inheritance.Subv2017-01-041-13/+45
| | | | | | | The implementation is based on reverse engineering of the 3DS's kernel. A mutex holder's priority will be temporarily boosted to the best priority among any threads that want to acquire any of its held mutexes. When the holder releases the mutex, it's priority will be boosted to the best priority among the threads that want to acquire any of its remaining held mutexes.
* Kernel: Object ShouldWait and Acquire calls now take a thread as a parameter.Subv2017-01-041-18/+6
| | | | This will be useful when implementing mutex priority inheritance.
* Kernel/Synch: Do not attempt a reschedule on every syscall.Subv2017-01-041-0/+1
| | | | Not all syscalls should cause reschedules, this commit attempts to remedy that, however, it still does not cover all cases.
* Use negative priorities to avoid special-casing the self-includeYuri Kunde Schlesner2016-09-211-1/+1
|
* Remove empty newlines in #include blocks.Emmanuel Gil Peyrot2016-09-211-4/+1
| | | | | | | This makes clang-format useful on those. Also add a bunch of forgotten transitive includes, which otherwise prevented compilation.
* Manually tweak source formatting and then re-run clang-formatYuri Kunde Schlesner2016-09-181-4/+2
|
* Sources: Run clang-format on everything.Emmanuel Gil Peyrot2016-09-181-2/+4
|
* kernel: Fix svcWaitSynch to always acquire requested wait objects.bunnei2015-06-161-8/+1
|
* Kernel: Move reschedules from SVCs to actual mechanisms that reschedule.bunnei2015-05-201-0/+2
|
* Common: Remove common.hYuri Kunde Schlesner2015-05-071-1/+1
|
* Kernel: Implemented priority inheritance for mutexes.bunnei2015-04-091-1/+9
|
* Asserts: break/crash program, fit to style guide; log.h->assert.harchshift2015-02-101-1/+1
| | | | | | | Involves making asserts use printf instead of the log functions (log functions are asynchronous and, as such, the log won't be printed in time) As such, the log type argument was removed (printf obviously can't use it, and it's made obsolete by the file and line printing) Also removed some GEKKO cruft.
* Mutex: Locks should be recursive.bunnei2015-02-091-14/+19
|
* Kernel: Stop creating useless Handles during object creationYuri Kunde Schlesner2015-02-021-4/+2
| | | | | They're finally unnecessary, and will stop cluttering the application's handle table.
* Kernel: Make WaitObjects share ownership of Threads waiting on themYuri Kunde Schlesner2015-02-021-2/+2
| | | | | | | | | | | | | | | | During normal operation, a thread waiting on an WaitObject and the object hold mutual references to each other for the duration of the wait. If a process is forcefully terminated (The CTR kernel has a SVC to do this, TerminateProcess, though no equivalent exists for threads.) its threads would also be stopped and destroyed, leaving dangling pointers in the WaitObjects. The solution is to simply have the Thread remove itself from WaitObjects when it is stopped. The vector of Threads in WaitObject has also been changed to hold SharedPtrs, just in case. (Better to have a reference cycle than a crash.)
* Explicitly instantiate constructors/destructors for Kernel objectsYuri Kunde Schlesner2015-02-021-0/+3
| | | | | | This should speed up compile times a bit, as well as enable more liberal use of forward declarations. (Due to SharedPtr not trying to emit the destructor anymore.)
generated by cgit v1.2.3 (git 2.39.1) at 2026-11-04 21:49:48 +0000