eglantine-cirakg - Mirror of github.com/cira0100/Eglantine-public nx2, a fork of Djihads80/Eglantine.

	Commit message (Collapse)	Author	Age	Files	Lines
*	game_list_worker: Use QString's formatting instead of fmt in ↵	Lioncash	2018-10-24	1	-4/+9
\| \| \| \| \| \| \| \|	FormatPatchNameVersions() Using fmt here requires unnecessary string conversions back into QString. Instead, we can just use QString's formatting and get the end result of the formatting operation in the proper type.
*	file_sys/registered_cache: Use unique_ptr and regular pointers instead of ↵	Lioncash	2018-10-16	1	-8/+11
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	shared_ptrs where applicable The data retrieved in these cases are ultimately chiefly owned by either the RegisteredCache instance itself, or the filesystem factories. Both these should live throughout the use of their contained data. If they don't, it should be considered an interface/design issue, and using shared_ptr instances here would mask that, as the data would always be prolonged after the main owner's lifetime ended. This makes the lifetime of the data explicit and makes it harder to accidentally create cyclic references. It also makes the interface slightly more flexible than the previous API, as a shared_ptr can be created from a unique_ptr, but not the other way around, so this allows for that use-case if it ever becomes necessary in some form.
*	patch_manager: Return a std::unique_ptr from ParseControlNCA() and ↵	Lioncash	2018-10-09	1	-6/+5
\| \| \| \| \| \| \| \| \| \| \| \| \| \| \| \|	GetControlMetadata() instead of a std::shared_ptr Neither of these functions require the use of shared ownership of the returned pointer. This makes it more difficult to create reference cycles with, and makes the interface more generic, as std::shared_ptr instances can be created from a std::unique_ptr, but the vice-versa isn't possible. This also alters relevant functions to take NCA arguments by const reference rather than a const reference to a std::shared_ptr. These functions don't alter the ownership of the memory used by the NCA instance, so we can make the interface more generic by not assuming anything about the type of smart pointer the NCA is contained within and make it the caller's responsibility to ensure the supplied NCA is valid.
*	romfs_factory: Extract packed update setter to new function	Zach Hilman	2018-10-05	1	-3/+2
\|
*	patch_manager: Add support for NSP packed updates	Zach Hilman	2018-10-05	1	-1/+8
\| \| \| \|	Reads as Update (NSP) in add-ons
*	game_list: Add XCI update versioning to game list	Zach Hilman	2018-10-05	1	-4/+8
\|
*	patch_manager: Use strings for patch type instead of enum	Zach Hilman	2018-10-01	1	-4/+3
\|
*	yuzu: Move compatibility list specifics to their own source files	Lioncash	2018-09-09	1	-3/+3
\| \| \| \| \| \| \|	Lets us keep the generic portions of the compatibility list code together, and allows us to introduce a type alias that makes it so we don't need to type out a very long type declaration anymore, making the immediate readability of some code better.
*	yuzu: Move GameListWorker to its own source files	Lioncash	2018-09-07	1	-0/+239
	This has gotten sufficiently large enough to warrant moving it to its own source files. Especially given it dumps the file_sys headers around code that doesn't use it for the most part. This'll also make it easier to introduce a type alias for the compatibility list, so a large unordered_map type declaration doesn't need to be specified all the time (we don't want to propagate the game_list_p.h include via the main game_list.h header).