From 315f6ef402cb0e5393113ba245f7a4da816590d0 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 19 Sep 2018 19:19:05 -0400 Subject: file-sys: Default heavy-weight class destructors in the cpp file Several classes have a lot of non-trivial members within them, or don't but likely should have the destructor defaulted in the cpp file for future-proofing/being more friendly to forward declarations. Leaving the destructor unspecified allows the compiler to inline the destruction code all over the place, which is generally undesirable from a code bloat perspective. --- src/core/file_sys/control_metadata.cpp | 2 ++ 1 file changed, 2 insertions(+) (limited to 'src/core/file_sys/control_metadata.cpp') diff --git a/src/core/file_sys/control_metadata.cpp b/src/core/file_sys/control_metadata.cpp index e76bf77bf0..0c90528a42 100644 --- a/src/core/file_sys/control_metadata.cpp +++ b/src/core/file_sys/control_metadata.cpp @@ -20,6 +20,8 @@ NACP::NACP(VirtualFile file) : raw(std::make_unique()) { file->ReadObject(raw.get()); } +NACP::~NACP() = default; + const LanguageEntry& NACP::GetLanguageEntry(Language language) const { if (language != Language::Default) { return raw->language_entries.at(static_cast(language)); -- cgit v1.2.3