From 3141019fcd01f7b8da310c1a1fb233866fe7cf93 Mon Sep 17 00:00:00 2001 From: lizzie Date: Sun, 7 Dec 2025 00:29:37 +0100 Subject: [qt, util] Change default units from units of 1024 (MiB, KiB) to 1000 (MB, KB) (#2882) Better for readability of these units? Perhaps Signed-off-by: lizzie Co-authored-by: crueter Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2882 Reviewed-by: crueter Reviewed-by: Maufeat Reviewed-by: Caio Oliveira Reviewed-by: CamilleLaVey Co-authored-by: lizzie Co-committed-by: lizzie --- src/frontend_common/data_manager.cpp | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) (limited to 'src/frontend_common/data_manager.cpp') diff --git a/src/frontend_common/data_manager.cpp b/src/frontend_common/data_manager.cpp index 1df828d028..e5f376720b 100644 --- a/src/frontend_common/data_manager.cpp +++ b/src/frontend_common/data_manager.cpp @@ -49,16 +49,13 @@ u64 ClearDir(DataDir dir, const std::string &user_id) return result; } -const std::string ReadableBytesSize(u64 size) -{ - static constexpr std::array units{"B", "KiB", "MiB", "GiB", "TiB", "PiB"}; - if (size == 0) { +std::string ReadableBytesSize(u64 size) noexcept { + std::array const units{"B", "KB", "MB", "GB", "TB", "PB"}; + u64 const base = 1000; + if (size == 0) return "0 B"; - } - - const int digit_groups = (std::min) (static_cast(std::log10(size) / std::log10(1024)), - static_cast(units.size())); - return fmt::format("{:.1f} {}", size / std::pow(1024, digit_groups), units[digit_groups]); + auto const digit_groups = std::min(u64(std::log10(size) / std::log10(base)), u64(units.size())); + return fmt::format("{:.1f} {}", size / std::pow(base, digit_groups), units[digit_groups]); } u64 DataDirSize(DataDir dir) -- cgit v1.2.3