From 6119e8fad2677e731e6105af6063cabe7be069f8 Mon Sep 17 00:00:00 2001 From: lizzie Date: Tue, 7 Jul 2026 19:52:22 +0200 Subject: [hid_core] fix LM2 crash due to callbacks not being removed properly (#4178) the function returned the key AFTER this one, which points to an invalid object basically its like "oh im returning the index AFTER Myself" off-by-1 error basically; now it returns OUR own key. Signed-off-by: lizzie Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4178 Reviewed-by: MaranBr Reviewed-by: CamilleLaVey --- src/hid_core/hid_core.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'src/hid_core/hid_core.cpp') diff --git a/src/hid_core/hid_core.cpp b/src/hid_core/hid_core.cpp index 12cd0c1f27..cbc193b741 100644 --- a/src/hid_core/hid_core.cpp +++ b/src/hid_core/hid_core.cpp @@ -24,7 +24,8 @@ HIDCore::HIDCore(Kernel::KernelCore& kernel_) , player_8{std::make_unique(NpadIdType::Player8)} , other{std::make_unique(NpadIdType::Other)} , handheld{std::make_unique(NpadIdType::Handheld)} - , console{std::make_unique()}, devices{std::make_unique()} + , console{std::make_unique()} + , devices{std::make_unique()} , kernel{kernel_} {} -- cgit v1.2.3