From 6fd10fd85eda83ce660f79bf6e5491806df2cf6d Mon Sep 17 00:00:00 2001 From: weakboson Date: Thu, 31 Jul 2025 17:47:29 +0200 Subject: [vk] Remove improper check for image depth in texture cache. (#164) When looking for existing images, ImageBase::TryFindBase checks the depth of the existing image to be greater than the layer of the base + depth of the candidate. However the depth of images are not updated when cache were merged causing the lookup to fail. This commit disables this faulty check to fix a critical memory leak that crashes the emulator in some games. Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/164 Co-authored-by: weakboson Co-committed-by: weakboson --- src/video_core/texture_cache/texture_cache.h | 1 + 1 file changed, 1 insertion(+) (limited to 'src/video_core/texture_cache/texture_cache.h') diff --git a/src/video_core/texture_cache/texture_cache.h b/src/video_core/texture_cache/texture_cache.h index 6c733fe902..78b6684c49 100644 --- a/src/video_core/texture_cache/texture_cache.h +++ b/src/video_core/texture_cache/texture_cache.h @@ -1426,6 +1426,7 @@ ImageId TextureCache

::JoinImages(const ImageInfo& info, GPUVAddr gpu_addr, DA if (solution) { gpu_addr = solution->gpu_addr; cpu_addr = solution->cpu_addr; + // TODO: properly update new_info.size.depth. new_info.resources = solution->resources; join_overlap_ids.push_back(overlap_id); join_copies_to_do.emplace_back(JoinCopy{false, overlap_id}); -- cgit v1.2.3