diff options
| author | rayman30 <silentbitdev@gmail.com> | 2026-01-30 18:06:57 +0100 |
|---|---|---|
| committer | crueter <crueter@eden-emu.dev> | 2026-01-30 18:06:57 +0100 |
| commit | 385b7cad77c3546082087c3993a3944c2050dd15 (patch) | |
| tree | ce9be0ca056061cf004a0ea353a0ab82a54a5efe /.patch | |
| parent | 7b537f6b727b180b09e62936f8d3344f891f3a7e (diff) | |
[macos] Fix infinite refresh loop in Game List (#3418)
On macOS, adding paths to QFileSystemWatcher can trigger immediate 'directoryChanged' signals (likely due to FSEvent behavior or .DS_Store updates during directory access). This caused a recursive loop where PopulateAsync would trigger itself indefinitely, leading to constant UI refreshing and high CPU usage.
This fix addresses the issue by:
1. Temporarily blocking QFileSystemWatcher signals while the watch list is being populated.
2. Correcting the usage of QList::mid() in the loop (passing length instead of an end index) to avoid massive path duplication.
These changes are isolated to macOS using #ifdef __APPLE__ to ensure no side effects on other platforms.
Authored-by: rayman30
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3418
Reviewed-by: Lizzie <lizzie@eden-emu.dev>
Reviewed-by: crueter <crueter@eden-emu.dev>
Co-authored-by: rayman30 <silentbitdev@gmail.com>
Co-committed-by: rayman30 <silentbitdev@gmail.com>
Diffstat (limited to '.patch')
0 files changed, 0 insertions, 0 deletions