diff options
| author | lizzie <lizzie@eden-emu.dev> | 2026-06-03 22:53:09 +0200 |
|---|---|---|
| committer | crueter <crueter@eden-emu.dev> | 2026-06-03 22:53:09 +0200 |
| commit | f729dbb3c3fbf30f06ff7c986f1a6761e3fb598f (patch) | |
| tree | b3369f3de816f743af5b7920cf69ef4c69fbe471 /externals | |
| parent | ec2b9b04001ebea637f01273ac8e6c17b2cc8390 (diff) | |
[common] use abi::__cxa_demangle for demangling using the system's glibcxx/libc++ (#3894)
most stdlibc++ already provide this functionality out of the box, very consistently and well implemented (usually)
my main irk is that the llvm itanium demangle is totally unescesary when there is a perfectly stable, tested and well documented equivalent functionality in the standard stdc++ provided in most UNIX oses
its mostly to reduce binary size by a very thin margin, but he stdc++ is more than capable of doing he same behaviour we use a dpeendency for
for mingw or such howeger,, demangling becomies trickier so we have to exclude windows entirely because well windows likes to do things differently dont they
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3894
Reviewed-by: crueter <crueter@eden-emu.dev>
Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Diffstat (limited to 'externals')
| -rw-r--r-- | externals/CMakeLists.txt | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/externals/CMakeLists.txt b/externals/CMakeLists.txt index 1aaa4c57ca..d4ac807322 100644 --- a/externals/CMakeLists.txt +++ b/externals/CMakeLists.txt @@ -49,8 +49,8 @@ if (NOT TARGET stb::headers) add_library(stb::headers ALIAS stb) endif() -# ItaniumDemangle -if (NOT TARGET LLVM::Demangle) +# ItaniumDemangle (Windows only) +if (WIN32 AND NOT TARGET LLVM::Demangle) add_library(demangle demangle/ItaniumDemangle.cpp) target_include_directories(demangle PUBLIC ./demangle) if (NOT MSVC) |