aboutsummaryrefslogtreecommitdiff
path: root/src/common/settings.cpp
diff options
context:
space:
mode:
authorcrueter <crueter@eden-emu.dev>2025-11-25 00:20:16 +0100
committercrueter <crueter@eden-emu.dev>2025-11-25 00:20:16 +0100
commit027085e5ba1c86c10805cd74fa728243da759cbf (patch)
tree1b5fa5a083d84372dac60a274e8c639f15aa2ebd /src/common/settings.cpp
parentf40025fd9bd29325452535f98705bd3442381fb5 (diff)
[desktop] fix audio output engine not saving (#3083)
This issue has like 15 different causes, and I'm surprised it took this long to pop up. 1. LoadString had a hack *specific* to the AudioEngine enum. Why? Solving this was easy, just use the explicit type ctor. -_- 2. The LoadString hack was abused in configure_audio.cpp to get around the canonicalization infrastructure that was explicitly put in to make this exact operation easier. Why? 3. ToString was also broken because of LoadString's garbage output. Technically it might work now, but it's better to just use the canonicalization infrastructure that was made specifically for this purpose. Also did a few tiny optimizations in config/settings cuz wynaut. Signed-off-by: crueter <crueter@eden-emu.dev> Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3083 Reviewed-by: Caio Oliveira <caiooliveirafarias0@gmail.com> Reviewed-by: MaranBr <maranbr@eden-emu.dev> Reviewed-by: Lizzie <lizzie@eden-emu.dev>
Diffstat (limited to 'src/common/settings.cpp')
0 files changed, 0 insertions, 0 deletions