aboutsummaryrefslogtreecommitdiff
path: root/src/common/sparse_large_vector.cpp
diff options
context:
space:
mode:
authorExverge <exverge@exverge.xyz>2026-09-23 13:52:29 +0200
committercrueter <crueter@eden-emu.dev>2026-09-23 13:52:29 +0200
commit38df54edfe7b861d0a0a1ee305836049a39d42ef (patch)
treeebd586cd501ee84feb6065393a62d80d15008390 /src/common/sparse_large_vector.cpp
parent3266c20e3f27a459449b77214182be3f0332e8f4 (diff)
[common/sparse_large_vector] decommit unused pages + fix first page in zeroed region (#4471)
- [x] I have read and followed the [Contribution Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions). - [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md) - [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md) to the best of my ability. ------------------- Fixes a bug where the first page of a zeroed out region would not be properly zeroed, and now frees unused memory. Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4471 Reviewed-by: lizzie <lizzie@eden-emu.dev> Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Diffstat (limited to 'src/common/sparse_large_vector.cpp')
-rw-r--r--src/common/sparse_large_vector.cpp15
1 files changed, 15 insertions, 0 deletions
diff --git a/src/common/sparse_large_vector.cpp b/src/common/sparse_large_vector.cpp
index ce6455a235..745575a880 100644
--- a/src/common/sparse_large_vector.cpp
+++ b/src/common/sparse_large_vector.cpp
@@ -96,6 +96,21 @@ bool CommitVectorPage(uintptr_t addr, bool write) noexcept {
#ifndef MAP_NOCORE
#define MAP_NOCORE 0
#endif
+#ifndef MADV_FREE
+#define MADV_FREE MADV_DONTNEED
+#endif
+
+void DecommitVectorPage(uintptr_t base) noexcept {
+#if defined(_WIN32)
+ VirtualFree(reinterpret_cast<LPVOID>(base), HostPageSize, MEM_DECOMMIT);
+#elif defined(__linux__)
+ // Linux's MADV_DONTNEED zeros out pages for us
+ madvise(reinterpret_cast<void*>(base), HostPageSize, MADV_DONTNEED);
+#else
+ madvise(reinterpret_cast<void*>(base), HostPageSize, MADV_FREE);
+ std::memset(reinterpret_cast<void*>(base), 0, HostPageSize);
+#endif
+}
void* AllocateMemoryPages(std::size_t size) noexcept {
if (auto page = HostPageSize; size % page != 0) {