diff options
| author | lizzie <lizzie@eden-emu.dev> | 2026-09-17 08:16:18 +0200 |
|---|---|---|
| committer | crueter <crueter@eden-emu.dev> | 2026-09-17 08:16:18 +0200 |
| commit | 1203082a8f1211ad6ce4d95f0c6947f7ecd27a55 (patch) | |
| tree | 47fbda810dc0d75ed960a1f609f7a1a7bf0c18f1 /src/common | |
| parent | 14235dc0d0543c7397dd19eb1a677e76114c08f3 (diff) | |
[msvc] fix build errors (#4451)
MSVC doesn't consider atomic<u64> to be trivially copyable on x86 (why?).
And other chary idiosyncrasies from constructing `std::optional<uint8_t>`
Signed-off-by: lizzie <lizzie@eden-emu.dev>
- [x] I have read and followed the [Contribution Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions).
- [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md)
- [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md) to the best of my ability.
-------------------
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4451
Reviewed-by: Maufeat <sahyno1996@gmail.com>
Reviewed-by: CamilleLaVey <camillelavey99@gmail.com>
Diffstat (limited to 'src/common')
| -rw-r--r-- | src/common/sparse_large_vector.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/common/sparse_large_vector.h b/src/common/sparse_large_vector.h index 827944fb08..dad3aea97e 100644 --- a/src/common/sparse_large_vector.h +++ b/src/common/sparse_large_vector.h @@ -38,7 +38,8 @@ void FreeMemoryPages(void* base, std::size_t size) noexcept; /// A large page-aligned buffer that has optimized memory usage for zero-writes. template <typename T> -requires std::is_trivially_copyable_v<T> + // MSVC doesn't regard structs with atomics as trivially copyable + // requires std::is_trivially_copyable_v<T> class SparseLargeVector final { public: constexpr SparseLargeVector() = default; |
