diff options
| author | Liam <byteslice@airmail.cc> | 2023-02-22 21:40:53 -0500 |
|---|---|---|
| committer | Liam <byteslice@airmail.cc> | 2023-03-01 10:42:45 -0500 |
| commit | dd0f9ff95043d356ad54a285dfa4ce10c8ce68ca (patch) | |
| tree | c9697c325ae6f1271b627ab7c93c5c84c2f9a13a /src/core/hle/kernel/k_address_arbiter.cpp | |
| parent | 1fd1d90c2d0ecdb03e8d74826661b9c142bb3312 (diff) | |
kernel: document previous location of interrupt disables in arbiter/condvar
Diffstat (limited to 'src/core/hle/kernel/k_address_arbiter.cpp')
| -rw-r--r-- | src/core/hle/kernel/k_address_arbiter.cpp | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/core/hle/kernel/k_address_arbiter.cpp b/src/core/hle/kernel/k_address_arbiter.cpp index a442a3b985..fb86451ea5 100644 --- a/src/core/hle/kernel/k_address_arbiter.cpp +++ b/src/core/hle/kernel/k_address_arbiter.cpp @@ -29,7 +29,9 @@ bool DecrementIfLessThan(Core::System& system, s32* out, VAddr address, s32 valu auto& monitor = system.Monitor(); const auto current_core = system.Kernel().CurrentPhysicalCoreIndex(); - // TODO(bunnei): We should disable interrupts here via KScopedInterruptDisable. + // NOTE: If scheduler lock is not held here, interrupt disable is required. + // KScopedInterruptDisable di; + // TODO(bunnei): We should call CanAccessAtomic(..) here. // Load the value from the address. @@ -59,7 +61,9 @@ bool UpdateIfEqual(Core::System& system, s32* out, VAddr address, s32 value, s32 auto& monitor = system.Monitor(); const auto current_core = system.Kernel().CurrentPhysicalCoreIndex(); - // TODO(bunnei): We should disable interrupts here via KScopedInterruptDisable. + // NOTE: If scheduler lock is not held here, interrupt disable is required. + // KScopedInterruptDisable di; + // TODO(bunnei): We should call CanAccessAtomic(..) here. // Load the value from the address. |