aboutsummaryrefslogtreecommitdiff
path: root/src/core/hle/service/acc/async_context.cpp
diff options
context:
space:
mode:
authorlizzie <lizzie@eden-emu.dev>2026-10-13 04:38:36 +0200
committercrueter <crueter@eden-emu.dev>2026-10-13 04:38:36 +0200
commit218c6705d950635bc18f8458d738a1996fb592b6 (patch)
tree2478ed42021c8f0624209fbb4821d4ee30265f63 /src/core/hle/service/acc/async_context.cpp
parent4dc69c06f764a235bccd01afbfc765d9ddbebc9f (diff)
[hle] constexpr handler dispatch maps, introduce version gating (#4480)
This PR primarily focuses on upbringing constexpr maps for handlers. Each time an HLE object of a service is construed, it registers it's own handlers, over and over. Regardless of whetever it needs them at the moment or not. Additionally we don't require to keep track of different function pointers amongst each object. This can be done by overriding the given function instead, as opposed to having a separate hash map for every given object. In other words: Remove handlers (and handlers_tipc) map for every instance then read from a static defined per-class. - [x] Migrate all HLE functions to new `frozen::map` constexpr time finder - [ ] Measure if this approach actually makes better codegen Optional: - [x] Properly gate all functions (that have versions commented next to them) - [x] Maybe store `HandlerFnP<>` and `const char*` separately, version gating can go in a different map as well Information such as name can be used on debug builds, but doesn't particularly help on release as one can consult an external reference (or have an annotated IPC map) Signed-off-by: lizzie <lizzie@eden-emu.dev> - [x] I have read and followed the [Contribution Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/CONTRIBUTING.md#code-contributions). - [x] I have read and followed the [AI Policy](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/AI.md) - [x] I have read and followed the [Coding Guidelines](https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/policies/Coding.md) to the best of my ability. ------------------- Co-authored-by: Maufeat <sahyno1996@gmail.com> Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4480 Reviewed-by: Maufeat <sahyno1996@gmail.com> Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Diffstat (limited to 'src/core/hle/service/acc/async_context.cpp')
-rw-r--r--src/core/hle/service/acc/async_context.cpp11
1 files changed, 0 insertions, 11 deletions
diff --git a/src/core/hle/service/acc/async_context.cpp b/src/core/hle/service/acc/async_context.cpp
index 8dec886ad7..a7f751d756 100644
--- a/src/core/hle/service/acc/async_context.cpp
+++ b/src/core/hle/service/acc/async_context.cpp
@@ -12,17 +12,6 @@
namespace Service::Account {
IAsyncContext::IAsyncContext(Core::System& system_)
: ServiceFramework{system_, "IAsyncContext"}, service_context{system_, "IAsyncContext"} {
- // clang-format off
- static const FunctionInfo functions[] = {
- {0, &IAsyncContext::GetSystemEvent, "GetSystemEvent"},
- {1, &IAsyncContext::Cancel, "Cancel"},
- {2, &IAsyncContext::HasDone, "HasDone"},
- {3, &IAsyncContext::GetResult, "GetResult"},
- };
- // clang-format on
-
- RegisterHandlers(functions);
-
completion_event = service_context.CreateEvent("IAsyncContext:CompletionEvent");
}