diff options
| author | lizzie <lizzie@eden-emu.dev> | 2025-11-04 22:35:34 +0100 |
|---|---|---|
| committer | crueter <crueter@eden-emu.dev> | 2025-11-04 22:35:34 +0100 |
| commit | 504df4856d85dba6c04a172f60259f9e71217d9e (patch) | |
| tree | 8b717a3a47bfeaeabaed86731984037fcc0f1e83 /src/core/loader/nro.cpp | |
| parent | 6abaee94a61b1cc07cf1eab6cc838b908d6c0a5b (diff) | |
[core/loader] Implement a bit improper ASLR (#2945)
A bit improper of an ASLR - it does something but something good? Who knows...
All I know is that there is a non-uniform distrobution for rand() and that rng_seed is likely a better solution?
I don't know
Signed-off-by: lizzie lizzie@eden-emu.dev
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/2945
Reviewed-by: Maufeat <sahyno1996@gmail.com>
Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Co-authored-by: lizzie <lizzie@eden-emu.dev>
Co-committed-by: lizzie <lizzie@eden-emu.dev>
Diffstat (limited to 'src/core/loader/nro.cpp')
| -rw-r--r-- | src/core/loader/nro.cpp | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/core/loader/nro.cpp b/src/core/loader/nro.cpp index 1d96dc4c89..a3cfa31be7 100644 --- a/src/core/loader/nro.cpp +++ b/src/core/loader/nro.cpp @@ -1,3 +1,6 @@ +// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project +// SPDX-License-Identifier: GPL-3.0-or-later + // SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project // SPDX-License-Identifier: GPL-2.0-or-later @@ -237,10 +240,14 @@ static bool LoadNroImpl(Core::System& system, Kernel::KProcess& process, return 0; }(); + // TODO: this is bad form of ASLR, it sucks + size_t aslr_offset = ((::Settings::values.rng_seed_enabled.GetValue() + ? ::Settings::values.rng_seed.GetValue() + : std::rand()) * 0x734287f27) & 0xfff000; + // Setup the process code layout if (process - .LoadFromMetadata(FileSys::ProgramMetadata::GetDefault(), image_size, fastmem_base, - false) + .LoadFromMetadata(FileSys::ProgramMetadata::GetDefault(), image_size, fastmem_base, aslr_offset, false) .IsError()) { return false; } |
