diff options
| author | comex <comexk@gmail.com> | 2020-11-22 16:05:18 -0500 |
|---|---|---|
| committer | comex <comexk@gmail.com> | 2020-11-23 17:58:49 -0500 |
| commit | bb729eefced13ffef7045746d5e9f26306892c8e (patch) | |
| tree | 82eaf8b6dea5baf60e17601771dc8191b8e69a8f /src/core/loader/nso.cpp | |
| parent | 7781ef2038a68e1a69f7d094ce9c4f5159971473 (diff) | |
Overhaul EmuWindow::PollEvents to fix yuzu-cmd calling SDL_PollEvents off main thread
EmuWindow::PollEvents was called from the GPU thread (or the CPU thread
in sync-GPU mode) when swapping buffers. It had three implementations:
- In GRenderWindow, it didn't actually poll events, just set a flag and
emit a signal to indicate that a frame was displayed.
- In EmuWindow_SDL2_Hide, it did nothing.
- In EmuWindow_SDL2, it did call SDL_PollEvents, but this is wrong
because SDL_PollEvents is supposed to be called on the thread that set
up video - in this case, the main thread, which was sleeping in a
busyloop (regardless of whether sync-GPU was enabled). On macOS this
causes a crash.
To fix this:
- Rename EmuWindow::PollEvents to OnFrameDisplayed, and give it a
default implementation that does nothing.
- In EmuWindow_SDL2, do not override OnFrameDisplayed, but instead have
the main thread call SDL_WaitEvent in a loop.
Diffstat (limited to 'src/core/loader/nso.cpp')
0 files changed, 0 insertions, 0 deletions
