[network, qt] use jthread and use std::vector for packet list instead of std::list (#254)

Signed-off-by: lizzie <lizzie@eden-emu.dev>
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/254
Reviewed-by: DraVee <dravee@eden-emu.dev>
Reviewed-by: Maufeat <sahyno1996@gmail.com>
Co-authored-by: lizzie <lizzie@eden-emu.dev>
Co-committed-by: lizzie <lizzie@eden-emu.dev>

4 files changed, 61 insertions, 113 deletions

diff --git a/src/yuzu/applets/qt_software_keyboard.cpp b/src/yuzu/applets/qt_software_keyboard.cpp
index 47b6629077..0b894bf51a 100644
--- a/src/yuzu/applets/qt_software_keyboard.cpp
+++ b/src/yuzu/applets/qt_software_keyboard.cpp
@@ -1,6 +1,5 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
 // SPDX-License-Identifier: GPL-3.0-or-later
-
 // SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project
 // SPDX-License-Identifier: GPL-2.0-or-later
 
@@ -1495,53 +1494,36 @@ void QtSoftwareKeyboardDialog::MoveTextCursorDirection(Direction direction) {
 }
 
 void QtSoftwareKeyboardDialog::StartInputThread() {
-    if (input_thread_running) {
-        return;
-    }
-
-    input_thread_running = true;
-
-    input_thread = std::thread(&QtSoftwareKeyboardDialog::InputThread, this);
+    input_thread = std::jthread([&](std::stop_token stoken) {
+        while (!stoken.stop_requested()) {
+            input_interpreter->PollInput();
+            HandleButtonPressedOnce<
+                Core::HID::NpadButton::A, Core::HID::NpadButton::B, Core::HID::NpadButton::X,
+                Core::HID::NpadButton::Y, Core::HID::NpadButton::StickL, Core::HID::NpadButton::StickR,
+                Core::HID::NpadButton::L, Core::HID::NpadButton::R, Core::HID::NpadButton::Plus,
+                Core::HID::NpadButton::Left, Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,
+                Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,
+                Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,
+                Core::HID::NpadButton::StickLDown, Core::HID::NpadButton::StickRLeft,
+                Core::HID::NpadButton::StickRUp, Core::HID::NpadButton::StickRRight,
+                Core::HID::NpadButton::StickRDown>();
+            HandleButtonHold<Core::HID::NpadButton::B, Core::HID::NpadButton::L,
+                Core::HID::NpadButton::R, Core::HID::NpadButton::Left,
+                Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,
+                Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,
+                Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,
+                Core::HID::NpadButton::StickLDown, Core::HID::NpadButton::StickRLeft,
+                Core::HID::NpadButton::StickRUp, Core::HID::NpadButton::StickRRight,
+                Core::HID::NpadButton::StickRDown>();
+            std::this_thread::sleep_for(std::chrono::milliseconds(50));
+        }
+    });
 }
 
 void QtSoftwareKeyboardDialog::StopInputThread() {
-    input_thread_running = false;
-
-    if (input_thread.joinable()) {
-        input_thread.join();
-    }
-
-    if (input_interpreter) {
+    input_thread.request_stop();
+    if (input_interpreter)
         input_interpreter->ResetButtonStates();
-    }
-}
-
-void QtSoftwareKeyboardDialog::InputThread() {
-    while (input_thread_running) {
-        input_interpreter->PollInput();
-
-        HandleButtonPressedOnce<
-            Core::HID::NpadButton::A, Core::HID::NpadButton::B, Core::HID::NpadButton::X,
-            Core::HID::NpadButton::Y, Core::HID::NpadButton::StickL, Core::HID::NpadButton::StickR,
-            Core::HID::NpadButton::L, Core::HID::NpadButton::R, Core::HID::NpadButton::Plus,
-            Core::HID::NpadButton::Left, Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,
-            Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,
-            Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,
-            Core::HID::NpadButton::StickLDown, Core::HID::NpadButton::StickRLeft,
-            Core::HID::NpadButton::StickRUp, Core::HID::NpadButton::StickRRight,
-            Core::HID::NpadButton::StickRDown>();
-
-        HandleButtonHold<Core::HID::NpadButton::B, Core::HID::NpadButton::L,
-                         Core::HID::NpadButton::R, Core::HID::NpadButton::Left,
-                         Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,
-                         Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,
-                         Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,
-                         Core::HID::NpadButton::StickLDown, Core::HID::NpadButton::StickRLeft,
-                         Core::HID::NpadButton::StickRUp, Core::HID::NpadButton::StickRRight,
-                         Core::HID::NpadButton::StickRDown>();
-
-        std::this_thread::sleep_for(std::chrono::milliseconds(50));
-    }
 }
 
 QtSoftwareKeyboard::QtSoftwareKeyboard(MainWindow& main_window) {
diff --git a/src/yuzu/applets/qt_software_keyboard.h b/src/yuzu/applets/qt_software_keyboard.h
index 4c03df10fc..66359ff11a 100644
--- a/src/yuzu/applets/qt_software_keyboard.h
+++ b/src/yuzu/applets/qt_software_keyboard.h
@@ -1,6 +1,5 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
 // SPDX-License-Identifier: GPL-3.0-or-later
-
 // SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project
 // SPDX-License-Identifier: GPL-2.0-or-later
 
@@ -185,9 +184,6 @@ private:
     void StartInputThread();
     void StopInputThread();
 
-    /// The thread where input is being polled and processed.
-    void InputThread();
-
     std::unique_ptr<Ui::QtSoftwareKeyboardDialog> ui;
 
     Core::System& system;
@@ -223,10 +219,7 @@ private:
     std::atomic<bool> caps_lock_enabled{false};
 
     std::unique_ptr<InputInterpreter> input_interpreter;
-
-    std::thread input_thread;
-
-    std::atomic<bool> input_thread_running{};
+    std::jthread input_thread;
 };
 
 class QtSoftwareKeyboard final : public QObject, public Core::Frontend::SoftwareKeyboardApplet {
diff --git a/src/yuzu/applets/qt_web_browser.cpp b/src/yuzu/applets/qt_web_browser.cpp
index 3d9d851ab6..2141b9d0e7 100644
--- a/src/yuzu/applets/qt_web_browser.cpp
+++ b/src/yuzu/applets/qt_web_browser.cpp
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
 // SPDX-License-Identifier: GPL-3.0-or-later
 
 // SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project
@@ -290,54 +290,41 @@ void QtNXWebEngineView::SendKeyPressEvent(int key) {
 }
 
 void QtNXWebEngineView::StartInputThread() {
-    if (input_thread_running) {
-        return;
-    }
+    input_thread = std::jthread([&](std::stop_token stoken) {
+        // Wait for 1 second before allowing any inputs to be processed.
+        std::this_thread::sleep_for(std::chrono::seconds(1));
+        if (is_local) {
+            QWidget::grabKeyboard();
+        }
+        while (!stoken.stop_requested()) {
+            input_interpreter->PollInput();
 
-    input_thread_running = true;
-    input_thread = std::thread(&QtNXWebEngineView::InputThread, this);
-}
+            HandleWindowFooterButtonPressedOnce<Core::HID::NpadButton::A, Core::HID::NpadButton::B,
+                                                Core::HID::NpadButton::X, Core::HID::NpadButton::Y,
+                                                Core::HID::NpadButton::L, Core::HID::NpadButton::R>();
 
-void QtNXWebEngineView::StopInputThread() {
-    if (is_local) {
-        QWidget::releaseKeyboard();
-    }
+            HandleWindowKeyButtonPressedOnce<
+                Core::HID::NpadButton::Left, Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,
+                Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,
+                Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,
+                Core::HID::NpadButton::StickLDown>();
 
-    input_thread_running = false;
-    if (input_thread.joinable()) {
-        input_thread.join();
-    }
-}
+            HandleWindowKeyButtonHold<
+                Core::HID::NpadButton::Left, Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,
+                Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,
+                Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,
+                Core::HID::NpadButton::StickLDown>();
 
-void QtNXWebEngineView::InputThread() {
-    // Wait for 1 second before allowing any inputs to be processed.
-    std::this_thread::sleep_for(std::chrono::seconds(1));
+            std::this_thread::sleep_for(std::chrono::milliseconds(50));
+        }
+    });
+}
 
+void QtNXWebEngineView::StopInputThread() {
     if (is_local) {
-        QWidget::grabKeyboard();
-    }
-
-    while (input_thread_running) {
-        input_interpreter->PollInput();
-
-        HandleWindowFooterButtonPressedOnce<Core::HID::NpadButton::A, Core::HID::NpadButton::B,
-                                            Core::HID::NpadButton::X, Core::HID::NpadButton::Y,
-                                            Core::HID::NpadButton::L, Core::HID::NpadButton::R>();
-
-        HandleWindowKeyButtonPressedOnce<
-            Core::HID::NpadButton::Left, Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,
-            Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,
-            Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,
-            Core::HID::NpadButton::StickLDown>();
-
-        HandleWindowKeyButtonHold<
-            Core::HID::NpadButton::Left, Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,
-            Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,
-            Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,
-            Core::HID::NpadButton::StickLDown>();
-
-        std::this_thread::sleep_for(std::chrono::milliseconds(50));
+        QWidget::releaseKeyboard();
     }
+    input_thread.request_stop();
 }
 
 void QtNXWebEngineView::LoadExtractedFonts() {
diff --git a/src/yuzu/applets/qt_web_browser.h b/src/yuzu/applets/qt_web_browser.h
index 70b6d8e050..6a2dd0c8ba 100644
--- a/src/yuzu/applets/qt_web_browser.h
+++ b/src/yuzu/applets/qt_web_browser.h
@@ -1,4 +1,4 @@
-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project
+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project
 // SPDX-License-Identifier: GPL-3.0-or-later
 
 // SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project
@@ -158,9 +158,6 @@ private:
     void StartInputThread();
     void StopInputThread();
 
-    /// The thread where input is being polled and processed.
-    void InputThread();
-
     /// Loads the extracted fonts using JavaScript.
     void LoadExtractedFonts();
 
@@ -168,24 +165,13 @@ private:
     void FocusFirstLinkElement();
 
     InputCommon::InputSubsystem* input_subsystem;
-
     std::unique_ptr<UrlRequestInterceptor> url_interceptor;
-
     std::unique_ptr<InputInterpreter> input_interpreter;
-
-    std::thread input_thread;
-
-    std::atomic<bool> input_thread_running{};
-
+    std::jthread input_thread;
     std::atomic<bool> finished{};
-
-    Service::AM::Frontend::WebExitReason exit_reason{
-        Service::AM::Frontend::WebExitReason::EndButtonPressed};
-
+    Service::AM::Frontend::WebExitReason exit_reason{Service::AM::Frontend::WebExitReason::EndButtonPressed};
     std::string last_url{"http://localhost/"};
-
     bool is_local{};
-
     QWebEngineProfile* default_profile;
     QWebEngineSettings* global_settings;
 };