[desktop] tas: add option to disable file overwrite dialog (#3657)

Hello everybody, thank you for letting me participate in the development of the Eden emulator!

I've been playing around with the TAS functionality and didn't want to always click "Yes" in the dialog that askes if I want to "Overwrite file of player 1?" after recording the inputs.
So I can't record and play TAS files with keybinds only, because I'd still need to switching from my contoller to my keyboard and back.

So I added the option "Show recording dialog" into the configure_tas screen.
(The final naming and string can be changed of course.)
It's a checkbox that is enabled by default (so no changes if ignored), but can be unchecked to disable the popup.
The change has been tested on top of the current master branch.

I've also created a commit to add the relevant translation data, where german is translated and the rest unfinished.
I'm not sure how this would be handled as this project uses transifex for it localization, so I can remove this commit if preferred.

Have a great day!
- Michi

Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/3657
Reviewed-by: crueter <crueter@eden-emu.dev>
Reviewed-by: CamilleLaVey <camillelavey99@gmail.com>
Co-authored-by: SchweGELBin <abramjannikmichael06@gmail.com>
Co-committed-by: SchweGELBin <abramjannikmichael06@gmail.com>

1 files changed, 9 insertions, 5 deletions

diff --git a/src/yuzu/main_window.cpp b/src/yuzu/main_window.cpp
index e02e02b413..688078385a 100644
--- a/src/yuzu/main_window.cpp
+++ b/src/yuzu/main_window.cpp
@@ -3665,13 +3665,17 @@ void MainWindow::OnTasRecord() {
 
     const bool is_recording = input_subsystem->GetTas()->Record();
     if (!is_recording) {
-        is_tas_recording_dialog_active = true;
+        if (Settings::values.tas_show_recording_dialog.GetValue()) {
+            is_tas_recording_dialog_active = true;
 
-        bool answer = question(this, tr("TAS Recording"), tr("Overwrite file of player 1?"),
-                               QMessageBox::Yes | QMessageBox::No, QMessageBox::Yes);
+            bool answer = question(this, tr("TAS Recording"), tr("Overwrite file of player 1?"),
+                                   QMessageBox::Yes | QMessageBox::No, QMessageBox::Yes);
 
-        input_subsystem->GetTas()->SaveRecording(answer);
-        is_tas_recording_dialog_active = false;
+            input_subsystem->GetTas()->SaveRecording(answer);
+            is_tas_recording_dialog_active = false;
+        } else {
+            input_subsystem->GetTas()->SaveRecording(true);
+        }
     }
     OnTasStateChanged();
 }