diff options
Diffstat (limited to 'src/video_core/dma_pusher.cpp')
| -rw-r--r-- | src/video_core/dma_pusher.cpp | 44 |
1 files changed, 8 insertions, 36 deletions
diff --git a/src/video_core/dma_pusher.cpp b/src/video_core/dma_pusher.cpp index 3e9359ea3f..2c0ba007ef 100644 --- a/src/video_core/dma_pusher.cpp +++ b/src/video_core/dma_pusher.cpp @@ -4,11 +4,9 @@ // SPDX-FileCopyrightText: Copyright 2021 yuzu Emulator Project // SPDX-License-Identifier: GPL-2.0-or-later -#include <cstdlib> #include "common/settings.h" #include "core/core.h" #include "video_core/dma_pusher.h" -#include "video_core/control/channel_state.h" #include "video_core/engines/maxwell_3d.h" #include "video_core/gpu.h" #include "video_core/guest_memory.h" @@ -31,38 +29,22 @@ DmaPusher::DmaPusher(Core::System& system_, MemoryManager& memory_manager_, Cont DmaPusher::~DmaPusher() = default; void DmaPusher::DispatchCalls() { + dma_pushbuffer_subindex = 0; dma_state.is_last_call = true; while (system.IsPoweredOn()) { if (!Step()) { break; } } - if (channel_state.native_abi && std::getenv("EDEN_NATIVE_DRAW_DIAGNOSTICS")) { - static u32 dispatch_traces{}; - if (dispatch_traces++ < 512) { - LOG_INFO(HW_GPU, "Native dispatch end: channel={}, queued={}, failed={}, acquire={}, method={:#x}, remaining={}, resume={}", - channel_state.bind_id, dma_pushbuffer.size(), HasFailedNativeWork(), - HasPendingNativeAcquire(), dma_state.method, dma_state.method_count, command_resume_offset); - } - } system.GPU().FlushCommands(); system.GPU().OnCommandListEnd(); } -bool DmaPusher::HasFailedNativeWork() const { - const auto& context = channel_state.native_macro_context; - return channel_state.native_abi && context && - (context->engine.native_execution_failed || context->compute_engine.native_execution_failed); -} - bool DmaPusher::Step() { - if (HasFailedNativeWork()) return false; if (!ib_enable || dma_pushbuffer.empty()) { return false; } - if (!puller.ResumeNativeAcquire(*this)) return false; - CommandList& command_list = dma_pushbuffer.front(); const size_t prefetch_size = command_list.prefetch_command_list.size(); @@ -75,10 +57,7 @@ bool DmaPusher::Step() { } if (prefetch_size > 0) { - const std::span<const CommandHeader> commands{command_list.prefetch_command_list}; - command_resume_offset += ProcessCommands(commands.subspan(command_resume_offset), command_resume_offset); - if (puller.HasPendingNativeAcquire() || HasFailedNativeWork()) return false; - command_resume_offset = 0; + ProcessCommands(command_list.prefetch_command_list); dma_pushbuffer.pop(); return true; } @@ -107,17 +86,13 @@ bool DmaPusher::Step() { const bool use_safe = Settings::IsDMALevelDefault() ? Settings::IsGPULevelHigh() : Settings::IsDMALevelSafe(); if (use_safe) { Tegra::Memory::GpuGuestMemory<Tegra::CommandHeader, Tegra::Memory::GuestMemoryFlags::SafeRead>headers(memory_manager, dma_state.dma_get, header.size, &command_headers); - const std::span<const CommandHeader> commands{headers.data(), headers.size()}; - command_resume_offset += ProcessCommands(commands.subspan(command_resume_offset), command_resume_offset); + ProcessCommands(headers); } else { Tegra::Memory::GpuGuestMemory<Tegra::CommandHeader, Tegra::Memory::GuestMemoryFlags::UnsafeRead>headers(memory_manager, dma_state.dma_get, header.size, &command_headers); - const std::span<const CommandHeader> commands{headers.data(), headers.size()}; - command_resume_offset += ProcessCommands(commands.subspan(command_resume_offset), command_resume_offset); + ProcessCommands(headers); } } - if (puller.HasPendingNativeAcquire() || HasFailedNativeWork()) return false; - command_resume_offset = 0; if (++dma_pushbuffer_subindex >= command_list_size) { dma_pushbuffer.pop(); dma_pushbuffer_subindex = 0; @@ -136,21 +111,20 @@ bool DmaPusher::Step() { return true; } -size_t DmaPusher::ProcessCommands(std::span<const CommandHeader> commands, size_t word_offset) { +void DmaPusher::ProcessCommands(std::span<const CommandHeader> commands) { for (size_t index = 0; index < commands.size();) { // Data word of methods command if (dma_state.method_count && dma_state.non_incrementing) { auto const& command_header = commands[index]; //must ref (MUltiMethod re) - dma_state.dma_word_offset = u64((word_offset + index) * sizeof(u32)); - u32 max_write = u32(std::min<std::size_t>(index + dma_state.method_count, commands.size()) - index); - if (channel_state.native_abi && dma_state.method < non_puller_methods) max_write = 1; + dma_state.dma_word_offset = u32(index * sizeof(u32)); + const u32 max_write = u32(std::min<std::size_t>(index + dma_state.method_count, commands.size()) - index); CallMultiMethod(&command_header.argument, max_write); dma_state.method_count -= max_write; dma_state.is_last_call = true; index += max_write; } else if (dma_state.method_count) { auto const command_header = commands[index]; //can copy - dma_state.dma_word_offset = u64((word_offset + index) * sizeof(u32)); + dma_state.dma_word_offset = u32(index * sizeof(u32)); dma_state.is_last_call = dma_state.method_count <= 1; CallMethod(command_header.argument); dma_state.method += !dma_state.non_incrementing ? 1 : 0; @@ -189,9 +163,7 @@ size_t DmaPusher::ProcessCommands(std::span<const CommandHeader> commands, size_ } index++; } - if (puller.HasPendingNativeAcquire() || HasFailedNativeWork()) return index; } - return commands.size(); } void DmaPusher::SetState(const CommandHeader& command_header) { |
