diff options
| author | lizzie <lizzie@eden-emu.dev> | 2026-07-07 19:52:22 +0200 |
|---|---|---|
| committer | crueter <crueter@eden-emu.dev> | 2026-07-07 19:52:22 +0200 |
| commit | 6119e8fad2677e731e6105af6063cabe7be069f8 (patch) | |
| tree | 157ca48f4940a560096f3842f9b49d0365f31a54 /src/hid_core/hid_core.cpp | |
| parent | bfc0e60333310c252e168b354ba3eb0802510864 (diff) | |
[hid_core] fix LM2 crash due to callbacks not being removed properly (#4178)
the function returned the key AFTER this one, which points to an invalid object
basically its like "oh im returning the index AFTER Myself"
off-by-1 error basically; now it returns OUR own key.
Signed-off-by: lizzie <lizzie@eden-emu.dev>
Reviewed-on: https://git.eden-emu.dev/eden-emu/eden/pulls/4178
Reviewed-by: MaranBr <maranbr@eden-emu.dev>
Reviewed-by: CamilleLaVey <camillelavey99@gmail.com>
Diffstat (limited to 'src/hid_core/hid_core.cpp')
| -rw-r--r-- | src/hid_core/hid_core.cpp | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/hid_core/hid_core.cpp b/src/hid_core/hid_core.cpp index 12cd0c1f27..cbc193b741 100644 --- a/src/hid_core/hid_core.cpp +++ b/src/hid_core/hid_core.cpp @@ -24,7 +24,8 @@ HIDCore::HIDCore(Kernel::KernelCore& kernel_) , player_8{std::make_unique<EmulatedController>(NpadIdType::Player8)} , other{std::make_unique<EmulatedController>(NpadIdType::Other)} , handheld{std::make_unique<EmulatedController>(NpadIdType::Handheld)} - , console{std::make_unique<EmulatedConsole>()}, devices{std::make_unique<EmulatedDevices>()} + , console{std::make_unique<EmulatedConsole>()} + , devices{std::make_unique<EmulatedDevices>()} , kernel{kernel_} {} |