diff options
| author | bunnei <bunneidev@gmail.com> | 2020-11-16 21:40:16 -0800 |
|---|---|---|
| committer | GitHub <noreply@github.com> | 2020-11-16 21:40:16 -0800 |
| commit | f4e1b9076cf0fd4f3fb84c8e7a30628ec84960b6 (patch) | |
| tree | ce02144d20896c3ae0ffe75643714467b5901e50 /src/input_common | |
| parent | ef3e76578a3c231e4ec0a248f7ccd505de2c1066 (diff) | |
| parent | eccf766a39d1ae425010af5fef0645ff78148fb6 (diff) | |
Merge pull request #4929 from lioncash/nodiscard-input
motion_input: Mark member functions as [[nodiscard]] where applicable
Diffstat (limited to 'src/input_common')
| -rw-r--r-- | src/input_common/motion_input.h | 23 |
1 files changed, 12 insertions, 11 deletions
diff --git a/src/input_common/motion_input.h b/src/input_common/motion_input.h index abb957f04b..efe74cf19a 100644 --- a/src/input_common/motion_input.h +++ b/src/input_common/motion_input.h @@ -13,7 +13,7 @@ namespace InputCommon { class MotionInput { public: - MotionInput(f32 new_kp, f32 new_ki, f32 new_kd); + explicit MotionInput(f32 new_kp, f32 new_ki, f32 new_kd); MotionInput(const MotionInput&) = default; MotionInput& operator=(const MotionInput&) = default; @@ -33,16 +33,17 @@ public: void UpdateRotation(u64 elapsed_time); void UpdateOrientation(u64 elapsed_time); - std::array<Common::Vec3f, 3> GetOrientation() const; - Common::Vec3f GetAcceleration() const; - Common::Vec3f GetGyroscope() const; - Common::Vec3f GetRotations() const; - Common::Quaternion<f32> GetQuaternion() const; - Input::MotionStatus GetMotion() const; - Input::MotionStatus GetRandomMotion(int accel_magnitude, int gyro_magnitude) const; - - bool IsMoving(f32 sensitivity) const; - bool IsCalibrated(f32 sensitivity) const; + [[nodiscard]] std::array<Common::Vec3f, 3> GetOrientation() const; + [[nodiscard]] Common::Vec3f GetAcceleration() const; + [[nodiscard]] Common::Vec3f GetGyroscope() const; + [[nodiscard]] Common::Vec3f GetRotations() const; + [[nodiscard]] Common::Quaternion<f32> GetQuaternion() const; + [[nodiscard]] Input::MotionStatus GetMotion() const; + [[nodiscard]] Input::MotionStatus GetRandomMotion(int accel_magnitude, + int gyro_magnitude) const; + + [[nodiscard]] bool IsMoving(f32 sensitivity) const; + [[nodiscard]] bool IsCalibrated(f32 sensitivity) const; private: void ResetOrientation(); |